Remove return types from all interfaces#75
Merged
alcaeus merged 1 commit intodoctrine:masterfrom Dec 16, 2019
Merged
Conversation
jwage
approved these changes
Dec 11, 2019
greg0ire
reviewed
Dec 11, 2019
This partially reverts commit 3e2fad5.
dcc3344 to
8b10068
Compare
greg0ire
approved these changes
Dec 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 3e2fad5.
To avoid a hard BC break from 1.x to 2.0, we remove the milestone, as that allows people to install either 1.x or 2.0.
With this, the upgrade process is as follows:
Doctrine\Common\Persistencenamespace in favour of theDoctrine\Persistencenamespace.^1.3 || ^2.0without further changes.^2.0 || ^3.0.This ensures a smooth transition where the ecosystem has time to catch up. Otherwise, a single package that upgrades to doctrine/persistence 2.0 could fast-travel a user into dependency hell. Projects are discouraged from running any single major version constraint - e.g. running
^2.0or^1.0is discouraged. Dependents should quickly ensure compatibility with 2.0 and update the version constraint as suggested above.