Skip to content

Add types to all interfaces.#50

Merged
jwage merged 1 commit intomasterfrom
types
Apr 24, 2019
Merged

Add types to all interfaces.#50
jwage merged 1 commit intomasterfrom
types

Conversation

@jwage
Copy link
Member

@jwage jwage commented Apr 17, 2019

  • Upgrades PHPUnit to 8
  • Upgrades PHPStan to 0.11
  • Adds phpstan/phpstan-strict-rules
  • Adds type hints everywhere and enables strict typing

@jwage jwage added this to the 2.0 milestone Apr 17, 2019
@ostrolucky
Copy link
Member

persistence 2.0, orm 3.0. Then we can continue with doctrine/orm#7130

@jwage jwage force-pushed the types branch 9 times, most recently from 9771b21 to 96e63a9 Compare April 18, 2019 19:55
@jwage jwage requested review from Ocramius and ostrolucky April 18, 2019 20:02
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments, otherwise great job

ostrolucky
ostrolucky previously approved these changes Apr 18, 2019
ostrolucky
ostrolucky previously approved these changes Apr 19, 2019
Ocramius
Ocramius previously approved these changes Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants