Bump PHPStan and Psalm#214
Merged
greg0ire merged 3 commits intodoctrine:2.2.xfrom Dec 2, 2021
drupol:patch-1
Merged
Conversation
Member
|
IIRC, using fixed versions rather than a range was meant to avoid getting new violations reported randomly in PRs not related to upgrading phpstan or psalm due to the CI picking a new version silently. |
Contributor
Author
|
Ok! I will amend. Had to run away, but will fix this asap before lunch |
Contributor
Author
|
Done, I updated the classes where the parameter name was not matching the interface. I did not modified the interfaces in order to avoid breaking stuff in some other external projects. |
greg0ire
approved these changes
Dec 2, 2021
Member
|
Thanks @drupol ! |
Contributor
Author
|
Merci :) |
derrabus
added a commit
to derrabus/persistence
that referenced
this pull request
Dec 19, 2021
* 2.2.x: Bump PHPStan and Psalm (doctrine#214) PHPStan 1.0.1
derrabus
added a commit
to derrabus/persistence
that referenced
this pull request
Dec 19, 2021
* 2.3.x: (24 commits) Bump PHPStan and Psalm (doctrine#214) Update `ObjectRepository`, more type inference. (doctrine#213) PHPStan 1.0.1 Reuse workflows from upstream Specify proxy type Undeprecate detach Fix class name Test on PHP 8.1 Deprecate short namespace alias syntax Normalize continuous integration workflow Add explicit `@return` type next to `#[ReturnTypeWillChange]` Describe criteria as array with string keys Allow null as return value for type of field Mark doctrine/annotations dependency as optional Allow null as a return value for association's target (doctrine#192) Add .github, .doctrine-project.json and phpstan-baseline.neon to export ignore Reordered property type resolution to resolve typed properties before untyped ones Merge 2.2.x into 2.3.x (doctrine#191) Don't pass null to strpos() (doctrine#190) Add ReturnTypeWillChange to extended reflection classes ...
derrabus
added a commit
that referenced
this pull request
Dec 19, 2021
* 2.3.x: (24 commits) Bump PHPStan and Psalm (#214) Update `ObjectRepository`, more type inference. (#213) PHPStan 1.0.1 Reuse workflows from upstream Specify proxy type Undeprecate detach Fix class name Test on PHP 8.1 Deprecate short namespace alias syntax Normalize continuous integration workflow Add explicit `@return` type next to `#[ReturnTypeWillChange]` Describe criteria as array with string keys Allow null as return value for type of field Mark doctrine/annotations dependency as optional Allow null as a return value for association's target (#192) Add .github, .doctrine-project.json and phpstan-baseline.neon to export ignore Reordered property type resolution to resolve typed properties before untyped ones Merge 2.2.x into 2.3.x (#191) Don't pass null to strpos() (#190) Add ReturnTypeWillChange to extended reflection classes ...
derrabus
added a commit
to derrabus/persistence
that referenced
this pull request
Dec 19, 2021
* 2.3.x: (24 commits) Bump PHPStan and Psalm (doctrine#214) Update `ObjectRepository`, more type inference. (doctrine#213) PHPStan 1.0.1 Reuse workflows from upstream Specify proxy type Undeprecate detach Fix class name Test on PHP 8.1 Deprecate short namespace alias syntax Normalize continuous integration workflow Add explicit `@return` type next to `#[ReturnTypeWillChange]` Describe criteria as array with string keys Allow null as return value for type of field Mark doctrine/annotations dependency as optional Allow null as a return value for association's target (doctrine#192) Add .github, .doctrine-project.json and phpstan-baseline.neon to export ignore Reordered property type resolution to resolve typed properties before untyped ones Merge 2.2.x into 2.3.x (doctrine#191) Don't pass null to strpos() (doctrine#190) Add ReturnTypeWillChange to extended reflection classes ...
derrabus
added a commit
to derrabus/persistence
that referenced
this pull request
Dec 19, 2021
* 2.3.x: (24 commits) Bump PHPStan and Psalm (doctrine#214) Update `ObjectRepository`, more type inference. (doctrine#213) PHPStan 1.0.1 Reuse workflows from upstream Specify proxy type Undeprecate detach Fix class name Test on PHP 8.1 Deprecate short namespace alias syntax Normalize continuous integration workflow Add explicit `@return` type next to `#[ReturnTypeWillChange]` Describe criteria as array with string keys Allow null as return value for type of field Mark doctrine/annotations dependency as optional Allow null as a return value for association's target (doctrine#192) Add .github, .doctrine-project.json and phpstan-baseline.neon to export ignore Reordered property type resolution to resolve typed properties before untyped ones Merge 2.2.x into 2.3.x (doctrine#191) Don't pass null to strpos() (doctrine#190) Add ReturnTypeWillChange to extended reflection classes ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.