Remove hard dependency on doctrine/annotations#198
Closed
wouterj wants to merge 1 commit intodoctrine:2.2.xfrom
Closed
Remove hard dependency on doctrine/annotations#198wouterj wants to merge 1 commit intodoctrine:2.2.xfrom
wouterj wants to merge 1 commit intodoctrine:2.2.xfrom
Conversation
|
Thanks Wouter! ... but this change was already merged in #197. |
Author
|
Oh, sorry! Thanks for letting me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be great to be able to remove
doctrine/annotationsin projects that fully migrated to attributes. While testing this, we discovered that this package has a hard dependency on it (and thus, it cannot be removed).The diff of this PR feels a bit weird: I couldn't find any dependency on
doctrine/annotationsin this project (other than the tests).The
AnnotationDriverdoes have a PHPdoc-only typehint toDoctrine\Common\Annotations\Reader. Thedoctrine/ormAttributeDriverextends this class, but passes a customAttributeReaderthat doesn't extend from the annotations reader. So I guess that's a reason why the typehint isn't a PHP typehint?