Drop backwards-compatibility layer#106
Conversation
|
A quick grep shows that this is very far from complete 😅 |
|
It also shows that another PR needs to be done to update the docs: they still refer to the outdated namespace. |
|
Regarding the docs, see #107 |
835fb9f to
925417c
Compare
Note sure if that's necessary. IMO, the following works fine:
|
|
My main point with this PR is that I don't touch dependencies version constraints, including and especially the php one, and that's what would make bumping to 2.0 and dropping the |
|
Ah, I see. So we'd be postponing the argument types to 3.0 to avoid dropping PHP 7.2 in 2.0, because that would make it ineligible for ORM 2.7? My head is spinning, but I think I understood. |
|
Yes, that's exactly my point. Note that it indeed means postponing argument types to 3.0, but that 3.0 can and should still happen very soon IMO. It's just that there would be an easier-to-upgrade-to intermediary step. |
|
If it makes upgrading ORM easier, sure :) |
|
I pushed this as 2.0.x :) |
Draft PR because I don't actually want to get this merged, this is just to show what the diff with 1.4.x is, and to (hopefully) get a green build. If this looks ok, then we could move 2.x to 3.x, and this branch to 2.x