Fatal error when upgrading to 2.0.4 and using ORM

[bizley]

BC Break Report

When executing cache:clear after composer update there is PHP fatal error.

PHP Fatal error:  Declaration of Doctrine\ORM\MappingClassMetadataFactory::wakeupReflection(Doctrine\Common\Persistence\Mapping\ClassMetadata $class, Doctrine\Common\Persistence\Mapping\ReflectionService $reflService) must be compatible with Doctrine\Persistence\MappingAbstractClassMetadataFactory::wakeupReflection(Doctrine\Persistence\Mapping\ClassMetadata $class, Doctrine\Persistence\Mapping\ReflectionService $reflService) in /var/www/html/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php on line 797

PHP Stack trace:
1. {main}() /var/www/html/bin/console:0
2. Symfony\Bundle\FrameworkBundle\Console\Application->run() /var/www/html/bin/console:44
3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() /var/www/html/vendor/symfony/console/Application.php:148
4. Symfony\Bundle\FrameworkBundle\Console\Application->registerCommands() /var/www/html/vendor/symfony/framework-bundle/Console/Application.php:65
5. App\Kernel->boot() /var/www/html/vendor/symfony/framework-bundle/Console/Application.php:159
6. App\Kernel->initializeContainer() /var/www/html/vendor/symfony/http-kernel/Kernel.php:136
7. Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp() /var/www/html/vendor/symfony/http-kernel/Kernel.php:658
8. ContainerEPFlGxJ\srcApp_KernelDevDebugContainer->{closure:/var/www/html/var/cache/dev/ContainerEPFlGxJ/getCacheWarmerService.php:12-25}() /var/www/html/vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php:89
9. ContainerEPFlGxJ\srcApp_KernelDevDebugContainer->load() /var/www/html/var/cache/dev/ContainerEPFlGxJ/getCacheWarmerService.php:17
10. require() /var/www/html/var/cache/dev/ContainerEPFlGxJ/srcApp_KernelDevDebugContainer.php:785
11. ContainerEPFlGxJ\srcApp_KernelDevDebugContainer->getValidator_BuilderService() /var/www/html/var/cache/dev/ContainerEPFlGxJ/getValidator_Mapping_CacheWarmerService.php:13
12. ContainerEPFlGxJ\srcApp_KernelDevDebugContainer->getDoctrine_Orm_DefaultEntityManagerService() /var/www/html/var/cache/dev/ContainerEPFlGxJ/srcApp_KernelDevDebugContainer.php:3127
13. Doctrine\ORM\EntityManager::create() /var/www/html/var/cache/dev/ContainerEPFlGxJ/srcApp_KernelDevDebugContainer.php:1111
14. Doctrine\ORM\EntityManager->__construct() /var/www/html/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:873
15. spl_autoload_call() /var/www/html/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:159
16. Symfony\Component\Debug\DebugClassLoader->loadClass() /var/www/html/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php:159

In ClassMetadataFactory.php line 797:
Compile Error: Declaration of Doctrine\ORM\Mapping\ClassMetadataFactory::wakeupReflection(Doctrine\Common\Persistence\Mapping\ClassMetadata $class, Doctrine\Common\Persistence\Mapping\ReflectionService $reflService) must be compatible with Doctrine\Persistence\Mapping\AbstractClassMetadataFactory::wakeupReflection(Doctrine\Persistence\Mapping\ClassMetadata $class, Doctrine\Persistence\Mapping\ReflectionService $reflService)

Q	A
BC Break	yes
Version	2.0.4

Package mongodb-odm is provided through doctrine/mongodb-odm-bundle (^4.0).
Adding fixed "doctrine/mongodb-odm": "2.0.3" to composer as a temporary fix does the trick.

[malarzm]

@greg0ire could this be related to doctrine/mongodb-odm#2150?

[greg0ire]

Uh yes, definitely, let me check

[greg0ire]

Doctrine\ORM\MappingClassMetadataFactory

Wait what?

[bizley]

Yea, I know. But mongodb-odm update triggers this. Not sure what is going on here but I'm happy to provide all the info you need.

[malarzm]

@bizley are you using ODM and ORM at the same time?

[bizley]

Yes.

[greg0ire]

Can you check which version of Doctrine persistence you use? I fear it misses yet another autoload call

[bizley]

1.3.4.

[alcaeus]

Meh, that’s a shame.

[alcaeus]

I believe we need to revisit the compat layer and namespace move entirely

[greg0ire]

@alcaeus not so fast, I think I found a mistake here: https://github.com/doctrine/persistence/blob/1.3.x/lib/Doctrine/Persistence/Mapping/ReflectionService.php#L74 : this line I wrote is clearly wrong, there should be Common in the namespace. But maybe that's what you were referring to?

@bizley can you try manually edit this file to add the Common part and report back?

[bizley]

Yup, changing line 74 to

interface_exists(\Doctrine\Common\Persistence\Mapping\ReflectionService::class);

fixed it. Or at least clearing the cache

[greg0ire]

I will make a PR tonight with that change, unless you beat me to it. I will also check other files in the project, and then make a release of doctrine/persistence. That should fix it. Sorry for this and thanks for reporting back.