Fix AbstractQuery::setParameter phpdoc#9504
Merged
derrabus merged 2 commits intodoctrine:2.11.xfrom Feb 12, 2022
Merged
Conversation
greg0ire
reviewed
Feb 11, 2022
| * strings and numeric types. | ||
| * @param string|int $key The parameter position or name. | ||
| * @param mixed $value The parameter value. | ||
| * @param string|int|null $type The parameter type. If specified, the given value will be run through |
Member
There was a problem hiding this comment.
Should we make this more precise?
Suggested change
| * @param string|int|null $type The parameter type. If specified, the given value will be run through | |
| * @param string|Connection::PARAM_*|ParameterType::*|null $type The parameter type. If specified, the given value will be run through |
Contributor
Author
There was a problem hiding this comment.
Is that something IDE's and static analyzers understand? 🤔
Member
There was a problem hiding this comment.
Static analyzers, yes. IDE, I don't know (I use neovim). Please test if you can.
Member
There was a problem hiding this comment.
AFAIK, we use this kind of literal type syntax only in annotations with psalm- vendor prefix, e.g. @psalm-param in this case.
Member
There was a problem hiding this comment.
Anyway, let's not go down that road in a bugfix PR.
derrabus
approved these changes
Feb 12, 2022
derrabus
added a commit
that referenced
this pull request
Feb 13, 2022
* 2.11.x: Fix AbstractQuery::setParameter phpdoc (#9504)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 14, 2022
* 2.12.x: Fix types on caches (doctrine#9507) Fix AbstractQuery::setParameter phpdoc (doctrine#9504) Added "false" value to $columnPrefix type declaration. (doctrine#9493)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be
Connection::PARAM_INT_ARRAYorConnection::PARAM_STR_ARRAYfor example and those areint