Add PHP 8.1 to CI #9006
Merged
Add PHP 8.1 to CI #9006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/php-8.1-ci
branch
2 times, most recently
from
9d00a25 to
f73f831
Compare
derrabus
commented
Sep 28, 2021
| @@ -68,7 +70,7 @@ public function typesShouldBeConvertedForDQLFunctions(): void | |||
| foreach ($query->getResult() as $i => $item) { | |||
| $product = self::PRODUCTS[$i]; | |||
|
|
|||
| self::assertSame(ltrim($product['price'], '-'), $item['absolute']); | |||
| self::assertEquals(ltrim($product['price'], '-'), $item['absolute']); | |||
There was a problem hiding this comment.
What was the reason to lower strictness for this assert?
There was a problem hiding this comment.
The type returned by the database driver is beyond our control. In PHP 8.1, various PDO drivers have become more type-aware and return integers and floats where we've received a string previously.
Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
force-pushed
the
improvement/php-8.1-ci
branch
from
f73f831 to
9f173ff
Compare
greg0ire
approved these changes
Oct 2, 2021
Merged
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 2, 2021
* 2.9.x: Run PHP 8.1 CI with stable dependencies (doctrine#9058) Duplicate testTwoIterateHydrations (doctrine#9048) Add PHP 8.1 to CI (doctrine#9006) Fix locking non-existing entity (doctrine#9053) Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 2, 2021
* 2.9.x: Run PHP 8.1 CI with stable dependencies (doctrine#9058) Duplicate testTwoIterateHydrations (doctrine#9048) Add PHP 8.1 to CI (doctrine#9006) Fix locking non-existing entity (doctrine#9053) Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 2, 2021
* 2.9.x: Run PHP 8.1 CI with stable dependencies (doctrine#9058) Duplicate testTwoIterateHydrations (doctrine#9048) Add PHP 8.1 to CI (doctrine#9006) Fix locking non-existing entity (doctrine#9053) Signed-off-by: Alexander M. Turek <me@derrabus.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Doctrine\Tests\ORM\Functional\Ticket\GH7941Test::typesShouldBeConvertedForDQLFunctions