Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining call to prefersSequences() #8942

Merged

Conversation

derrabus
Copy link
Member

This PR removes one call to prefersSequences() that slipped my eye. Here it is used to skip a test for platforms that don't "prefer" sequences.

While that test certainly was meant to reproduce a bug that occurred with sequences, I'm unsure if we really need to skip it in other environments.

Signed-off-by: Alexander M. Turek <me@derrabus.de>
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it in fact works on those databases

@derrabus derrabus added this to the 2.10.0 milestone Aug 23, 2021
@derrabus derrabus merged commit 7446569 into doctrine:2.10.x Aug 23, 2021
@derrabus derrabus deleted the bugfix/prefers-sequences-in-tests branch August 23, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants