Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring more tests #8904

Merged
merged 4 commits into from
Aug 14, 2021
Merged

Conversation

carnage
Copy link
Contributor

@carnage carnage commented Aug 9, 2021

Backport of #6854 I think I've got all the merge conflicts resolved correctly, but this may need a couple of attempts to get it right. Code review should compare original PR to this one to make sure that the changes included here make sense.

@carnage carnage force-pushed the refactoring-tests-backport branch from 7714be1 to f573214 Compare August 14, 2021 10:44
@carnage carnage force-pushed the refactoring-tests-backport branch from f573214 to f34215d Compare August 14, 2021 10:47
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@greg0ire greg0ire merged commit aee197f into doctrine:2.10.x Aug 14, 2021
@greg0ire
Copy link
Member

Thanks @carnage !

@carnage carnage deleted the refactoring-tests-backport branch August 15, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants