Deprecate EntityRepository#clear() #7928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Nov 27, 2019
lcobucci
suggested changes
Nov 28, 2019
Member
lcobucci
left a comment
lcobucci
left a comment
There was a problem hiding this comment.
Thank you for your contribution here! Just a few minor things and we should also add a test verifying the deprecation message (if we keep it).
SenseException
approved these changes
Dec 2, 2019
lcobucci
force-pushed
the
2.7-patch-deprecated
branch
from
560deb0 to
fd5dab8
Compare
lcobucci
approved these changes
Dec 9, 2019
lcobucci
changed the title
lcobucci
force-pushed
the
2.7-patch-deprecated
branch
from
fd5dab8 to
59e3a55
Compare
This was referenced Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clear with entity class, generate a deprecated warning.
maybe better to remove the class name.
Closes #7925 , Closes #7922