Fixes #7039 paginator count with instance of return 0 - #12529
Open
Si-gi wants to merge 2 commits into
Open
Conversation
When a custom ResultSetMapping is set on a query, as the Paginator does for its count query, the discriminator parameters recorded by the SqlWalker in the parsed RSM were ignored: a ClassMetadata bound to an INSTANCE OF expression was bound as its FQCN instead of the discriminator values, so count() always returned 0 while iterating the very same Paginator returned the expected results. Resolve discriminator parameters against the parser result RSM, which is always populated once the query has been parsed, keeping the user-provided RSM as a fallback. Fixes doctrine#7039 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Paginator count with INSTANCE OF parameter return 0
Fixes #7039
When a custom ResultSetMapping is set on a query, as the Paginator does for its count query, discriminator parameters recorded by the SqlWalker in the parsed RSM were ignored
A ClassMetadata bound to an INSTANCE OF expression was bound as its FQCN instead of the discriminator values, so the count was always 0.
This PR resolve discriminator parameters against the parser result's RSM, which is always populated once the query has been parsed.
I added
$parsedRsm = $this->parserResult->getResultSetMapping();in Query:resolveParameterValue() and updated the conditions on discriminatorParameters to use parsedRsm by default.I added a test 7039 as asked by contribution guidline