Fix collection filtering API for IN/NOT IN comparisons that require type conversions
#12190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype conversions This PR fixes the `Criteria` matching API for `IN` and `NIN` conditions with values that are arrays, by making sure that type information for the matched field is passed to the DBAL level correctly. Passing the right parameter type to DBAL is important to make sure parameter conversions are applied before matching at the database level. Memory-based collections (`ArrayCollection`s or initialized collection fields) would perform matching on the objects in memory where no type conversion to the database representation is required, giving correct results. But uninitialized collections that have their conditions evaluated at the database level need to convert parameter values to the database representation before performing the comparison. One extra challenge is that the DBAL type system does currently not support array-valued parameters for custom types. Only a [limited list of types](https://www.doctrine-project.org/projects/doctrine-dbal/en/4.2/reference/data-retrieval-and-manipulation.html#list-of-parameters-conversion) is supported. I discussed this with @morozov at the Doctrine Hackathon and came to the conclusion that it would be best to work around this limitation at the ORM level. Thus, this fix recognizes array-valued parameters and creates multiple placeholders (like `?, ?, ?`) for them, flattening out the arrays in the parameter list and repeating the type information for each one of them. Previous stalled attempt to fix this was in doctrine#11897.
mpdude
force-pushed
the
criteria-matching-custom-type-retry
branch
from
f6d4c47 to
bd86a47
Compare
morozov
previously approved these changes
Oct 9, 2025
|
The commits would need to be squashed either by you or the person who merges. |
greg0ire
reviewed
Oct 10, 2025
|
|
||
| $matching = new OwningManyToManyEntity(); | ||
| $matching->id2 = 'first'; | ||
| $matching->field = 'match this'; |
There was a problem hiding this comment.
I asked Claude how this test had to do with conversion, and when I understood, how to make it more obvious, it suggested to add comments here and below. There are other suggestions but this is the one I think would be the most appropriate.
Suggested change
| $matching->field = 'match this'; | |
| $matching->field = 'match this'; // stored as 'zngpu guvf' |
Comment on lines
+62
to
+63
| yield [Criteria::expr()->eq('field', 'match this')]; | ||
| yield [Criteria::expr()->in('field', ['match this'])]; |
There was a problem hiding this comment.
Suggested change
| yield [Criteria::expr()->eq('field', 'match this')]; | |
| yield [Criteria::expr()->in('field', ['match this'])]; | |
| yield [Criteria::expr()->eq('field', 'match this')]; // should convert to 'zngpu guvf' | |
| yield [Criteria::expr()->in('field', ['match this'])]; // should convert to ['zngpu guvf'] |
There was a problem hiding this comment.
If you agree, please do the same for the other test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
Criteriamatching API forINandNINconditions with values that are arrays, by making sure that type information for the matched field is passed to the DBAL level correctly.Passing the right parameter type to DBAL is important to make sure parameter conversions are applied before matching at the database level.
Memory-based collections (
ArrayCollections or initialized collection fields) would perform matching on the objects in memory where no type conversion to the database representation is required, giving correct results.But uninitialized collections that have their conditions evaluated at the database level need to convert parameter values to the database representation before performing the comparison.
One extra challenge is that the DBAL type system does currently not support array-valued parameters for custom types. Only a limited list of types is supported.
I discussed this with @morozov at the Doctrine Hackathon and came to the conclusion that it would be best to work around this limitation at the ORM level. Thus, this fix recognizes array-valued parameters and creates multiple placeholders (like
?, ?, ?) for them, flattening out the arrays in the parameter list and repeating the type information for each one of them.Previous stalled attempt to fix this was in #11897.