Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow classname in 'value' attribute of xml discriminator-mapping field #11450

Closed
wants to merge 777 commits into from
Closed

Allow classname in 'value' attribute of xml discriminator-mapping field #11450

wants to merge 777 commits into from

Conversation

MatteoFeltrin
Copy link
Contributor

@MatteoFeltrin MatteoFeltrin commented May 13, 2024

fixes #11449

In relation to #10630
This PR allows a more loosen validation of the value attribute of discriminator-mapping field, using orm:type in the XSD schema as it was done in the linked pull request.
The test I written loads the entity enabling the validation against XSD schema, thus expects no exception to be thrown.

greg0ire and others added 30 commits May 15, 2023 09:10
Not sure how I forgot these.
Narrow down parameter types for quote strategies
This must have been lost when merging up d7d6b9d
It does not seem to ever be empty
Make the join table name and join column name mandatory
Migrate to the object API of Join{Column,Table}Mapping
The linked issue has been addressed, this rules should have been removed
during a merge up, as it is no longer present on 2.x
That property has been removed from 3.0.x
Note that we also remove UpdateCommandTest::testItPrintsTheSql() because
it relied on not passing --complete to work.
greg0ire and others added 23 commits March 17, 2024 09:38
Avoid another occurrence of ArrayAccess
Merge 2.19.x up into 3.1.x
To reduce Algolia operations and indexes older versions get removed
Fixed proxy initialization for EnumReflectionProperty
* 2.19.x:
  Set column length explicitly (#11393)
  Add missing import
  Remove unused variable (#11391)
  [Documentation] Removing "Doctrine Mapping Types" ... (#11384)
  [GH-11185] Bugfix: do not use collection batch loading for indexBy assocations. (#11380)
  Improve lazy ghost performance by avoiding self-referencing closure. (#11376)
SchemaValidator: Changing mapping of BIGINT to string|int
docs: update PHP version in doc
* 2.19.x:
  Fix BIGINT validation (#11414)
  Fix templated phpdoc return type (#11407)
  [Documentation] Merging "Query Result Formats" with "Hydration Modes"
  Fix psalm errors: remove override of template type
  Update dql-doctrine-query-language.rst
  Adding `NonUniqueResultException`
  [Documentation] Query Result Formats
Merge 3.0.x up into 3.1.x
Targeting 2.19.x, since we want the updates to bubble up. Since
Dependabot has had no effect on doctrine/dbal yet, I suppose that means
that "dependabot.yml" must be present on the default branch.
@greg0ire
Copy link
Member

According to #11208, you're probably not targeting the right branch.

@MatteoFeltrin MatteoFeltrin changed the base branch from 3.1.x to 2.19.x May 14, 2024 07:02
@MatteoFeltrin
Copy link
Contributor Author

Closing to start from the correct branch

@greg0ire
Copy link
Member

@MatteoFeltrin it is possible to retarget a PR with the edit button.

@MatteoFeltrin
Copy link
Contributor Author

@greg0ire sorry for my ignorance, it was the first time contributing to an upstream repository, I forked with only with 3.1.x branch and didn't know how to add the correct one, so preferred to do it from scratch 😅

@greg0ire
Copy link
Member

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow FQCN in value attribute of discriminator-mapping field