Mention that postRemove may still see removed entities in in-memory collections
#11146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry collections ... plus minor tweaks.
greg0ire
approved these changes
Jan 2, 2024
SenseException
approved these changes
Jan 2, 2024
|
#11132 might change this a tad to also update the in-memory collections before the event is omitted. OTOH, this consistency isn't guaranteed for the other events either, so I am not sure it's worth to bother about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... plus minor tweaks.
Depending on how we proceed with #11132, we might want to document that
post*Events should not expect collections to be in a clean state, and that the transaction has not yet been committed at that point.The warning about
flush()reentrance belongs to a more general place, not only topostPersist/postRemove/postUpdateevents.