Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in-memory collections before dispatching the postRemove event #11132

Closed
wants to merge 1 commit into from

Commits on Jan 2, 2024

  1. Make sure in-memory collections have removed entities unset before th…

    …e `postRemove` event is dispatched. This is related to #11098, although by itself probably not going to fix the regression.
    
    #### Background 
    
    When an entity is removed from the database, the UoW also takes care of removing that entity from all in-memory collections. #10763 moved this cleanup and taking snapshots of updated collections to a very late stage during the commit phase, in order to avoid other side effects.
    
    Now, part of the issue in #11098 is that `postRemove` event listeners will be called at a point where the database-level `DELETE` has happened (although the transaction has not yet been committed), but the in-memory collections have not yet been updated.
    
    #### Suggested change
    
    This PR moves the code part that unsets removed entities from in-memory collections and takes collection snapshots (makes collections "clean") from after transaction commit to before the `postRemove` event. That brings the in-memory update closer to the database-level execution.
    
    In the case of a transaction failure/abort, this leaves us with updated and snapshotted in-memory collections, but no database-level updates. But, at this point, probably things got inconsistent anyways, the EM will be closed and we need not be too worried about the state.
    mpdude committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    6d72e24 View commit details
    Browse the repository at this point in the history