Fix calls to removed lock methods #11061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
bugfix/lock-sql
branch
2 times, most recently
from
a63c8d6
to
532f566
Compare
derrabus
force-pushed
the
bugfix/lock-sql
branch
from
532f566
to
95bec67
Compare
|
I'm merging this so we have a green pipeline again. |
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Jan 28, 2024
These deprecations have been handled on 4.0.x in doctrine#11061, it is safe to ignore them.
|
@derrabus should this be backported to 2.x so that we're not relying on deprecated DBAL methods in the ORM? |
|
We can do that, yes. |
|
I will make a PR for 2.17.x |
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
jwage
pushed a commit
to jwage/orm
that referenced
this pull request
Jan 30, 2024
greg0ire
added a commit
that referenced
this pull request
Jan 31, 2024
Fix calls to removed lock methods (#11061)
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getReadLockSQL()andgetWriteLockSQL()have been removed from the DBAL. This PR restores the functionality in order to get the pipeline green again. I'll try to leverage the DBAL query builder instead when I find some time. 😓