Merge up 2.17.x to 3.0.x #10994
Merged
Merge up 2.17.x to 3.0.x #10994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we assert a given exception should be thrown, and get this instead, it is hard to figure out what went wrong.
Add method name in exception
What was optimal 10 years ago no longer is, and things might change in the future. Using AUTO is still the best solution in most cases, and it should be easy to make it mean something else when it is not.
greg0ire
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly merges up #8931
The behavior is changed that the deprecation is removed, and instead IDENTITY is always determined to be the default strategy except for a list of platforms with non defaults. This list only includes Oracle with Sequence for now.