Add compatibility with the Symfony 4.4 VarExporter

doctrine · Oct 19, 2023 · a936549 · a936549
1 parent 38ad392
commit a936549
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/lib/Doctrine/ORM/Query/ParserResult.php b/lib/Doctrine/ORM/Query/ParserResult.php
@@ -141,7 +141,9 @@ public function __unserialize(array $data): void
     {
         foreach (self::LEGACY_PROPERTY_MAPPING as $property => $legacyProperty) {
             $this->$property = $data[sprintf("\0%s\0%s", self::class, $legacyProperty)]
+                ?? $data[self::class][$legacyProperty]
                 ?? $data[sprintf("\0%s\0%s", self::class, $property)]
+                ?? $data[self::class][$property]
                 ?? $this->$property
                 ?? null;
         }

diff --git a/tests/Doctrine/Tests/ORM/Functional/ParserResultSerializationTest.php b/tests/Doctrine/Tests/ORM/Functional/ParserResultSerializationTest.php
@@ -4,15 +4,20 @@
 
 namespace Doctrine\Tests\ORM\Functional;
 
+use Composer\InstalledVersions;
+use Composer\Semver\VersionParser;
 use Doctrine\ORM\Query;
+use Doctrine\ORM\Query\Exec\AbstractSqlExecutor;
 use Doctrine\ORM\Query\Exec\SingleSelectExecutor;
 use Doctrine\ORM\Query\ParserResult;
 use Doctrine\ORM\Query\ResultSetMapping;
 use Doctrine\Tests\OrmFunctionalTestCase;
 use Generator;
 use ReflectionMethod;
+use Symfony\Component\VarExporter\VarExporter;
 
 use function file_get_contents;
+use function file_put_contents;
 use function rtrim;
 use function serialize;
 use function unserialize;
@@ -61,6 +66,35 @@ public static function provideSerializedSingleSelectResults(): Generator
         yield '2.15.0' => [rtrim(file_get_contents(__DIR__ . '/ParserResults/single_select_2_15_0.txt'), "\n")];
     }
 
+    public function testSymfony44ProvidedData(): void
+    {
+        if (InstalledVersions::satisfies(new VersionParser(), 'symfony/var-exporter', '^4.0.0') === false) {
+            $this->markTestSkipped('This issue only happens on `symfony/var-exporter` version `4`');
+        }
+
+        $sqlExecutor      = $this->createMock(SingleSelectExecutor::class);
+        $resultSetMapping = $this->createMock(ResultSetMapping::class);
+
+        $tempFile = 'symfony_44-temp.php';
+
+        $parserResult = new ParserResult();
+        $parserResult->setSqlExecutor($sqlExecutor);
+        $parserResult->setResultSetMapping($resultSetMapping);
+        $parserResult->addParameterMapping('name', 0);
+
+        $exported = VarExporter::export($parserResult);
+        $data     = file_put_contents($tempFile, '<?php return ' . $exported . ';');
+
+        $unserialized = require $tempFile;
+
+        $this->assertInstanceOf(ParserResult::class, $unserialized);
+        $this->assertInstanceOf(ResultSetMapping::class, $unserialized->getResultSetMapping());
+        $this->assertEquals(['name' => [0]], $unserialized->getParameterMappings());
+        $this->assertInstanceOf(SingleSelectExecutor::class, $unserialized->getSqlExecutor());
+
+        unlink($tempFile);
+    }
+
     private static function parseQuery(Query $query): ParserResult
     {
         $r = new ReflectionMethod($query, 'parse');