Add method name in exception

When we assert a given exception should be thrown, and get this instead, it is hard to figure out what went wrong.
doctrine · Oct 10, 2023 · 194f506 · 194f506
1 parent 48edb33
commit 194f506
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 7 deletions.
diff --git a/tests/Doctrine/Tests/Mocks/ConnectionMock.php b/tests/Doctrine/Tests/Mocks/ConnectionMock.php
@@ -87,12 +87,18 @@ public function delete($table, array $criteria, array $types = [])
      */
     public function fetchColumn($statement, array $params = [], $colunm = 0, array $types = [])
     {
-        throw new BadMethodCallException('Call to deprecated method.');
+        throw new BadMethodCallException(sprintf(
+            'Call to deprecated method %s().',
+            __METHOD__
+        ));
     }
 
     public function query(?string $sql = null): Result
     {
-        throw new BadMethodCallException('Call to deprecated method.');
+        throw new BadMethodCallException(sprintf(
+            'Call to deprecated method %s().',
+            __METHOD__
+        ));
     }
 
     /**

diff --git a/tests/Doctrine/Tests/Mocks/DatabasePlatformMock.php b/tests/Doctrine/Tests/Mocks/DatabasePlatformMock.php
@@ -8,14 +8,19 @@
 use Doctrine\DBAL\Exception as DBALException;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 
+use function sprintf;
+
 /**
  * Mock class for DatabasePlatform.
  */
 class DatabasePlatformMock extends AbstractPlatform
 {
     public function prefersIdentityColumns(): bool
     {
-        throw new BadMethodCallException('Call to deprecated method.');
+        throw new BadMethodCallException(sprintf(
+            'Call to deprecated method %s().',
+            __METHOD__
+        ));
     }
 
     public function supportsIdentityColumns(): bool
@@ -25,7 +30,10 @@ public function supportsIdentityColumns(): bool
 
     public function prefersSequences(): bool
     {
-        throw new BadMethodCallException('Call to deprecated method.');
+        throw new BadMethodCallException(sprintf(
+            'Call to deprecated method %s().',
+            __METHOD__
+        ));
     }
 
     public function supportsSequences(): bool
@@ -94,7 +102,10 @@ public function getClobTypeDeclarationSQL(array $field)
 
     public function getName(): string
     {
-        throw new BadMethodCallException('Call to deprecated method.');
+        throw new BadMethodCallException(sprintf(
+            'Call to deprecated method %s().',
+            __METHOD__
+        ));
     }
 
     /**

diff --git a/tests/Doctrine/Tests/Mocks/DriverMock.php b/tests/Doctrine/Tests/Mocks/DriverMock.php
@@ -12,6 +12,8 @@
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
 use Exception;
 
+use function sprintf;
+
 /**
  * Mock class for Driver.
  */
@@ -70,7 +72,10 @@ public function setSchemaManager(AbstractSchemaManager $sm): void
      */
     public function getName()
     {
-        throw new BadMethodCallException('Call to deprecated method.');
+        throw new BadMethodCallException(sprintf(
+            'Call to deprecated method %s().',
+            __METHOD__
+        ));
     }
 
     /**

diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3634Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3634Test.php
@@ -20,6 +20,7 @@
 use Doctrine\Tests\OrmFunctionalTestCase;
 
 use function debug_backtrace;
+use function sprintf;
 
 use const PHP_INT_MAX;
 
@@ -347,7 +348,10 @@ public function query($sql = null): Result
     /** {@inheritDoc} */
     public function executeUpdate($query, array $params = [], array $types = []): int
     {
-        throw new BadMethodCallException('Call to deprecated method.');
+        throw new BadMethodCallException(sprintf(
+            'Call to deprecated method %s().',
+            __METHOD__
+        ));
     }
 
     /** {@inheritDoc} */