Skip to content
Coding Standards

Got rid of redundant JOINs/WHEREs of WhereInWalker #3492

Sign in to view logs

Got rid of redundant JOINs/WHEREs of WhereInWalker

Got rid of redundant JOINs/WHEREs of WhereInWalker #3492

Triggered via pull request October 20, 2024 09:27
@SerheyDolgushevSerheyDolgushev
synchronize #10917
SerheyDolgushev:fix/paginator-skip-redunand-joins
Status Failure
Total duration 43s
Artifacts –

coding-standards.yml

on: pull_request
coding-standards  /  Coding Standards (PHP: 8.3)
31s
coding-standards / Coding Standards (PHP: 8.3)
Fit to window
Zoom out
Zoom in

Annotations

8 errors
coding-standards / Coding Standards (PHP: 8.3): src/Tools/Pagination/Paginator.php#L277
Non-capturing catch is required.
coding-standards / Coding Standards (PHP: 8.3): src/Tools/Pagination/WhereInWalker.php#L167
Method \Doctrine\ORM\Tools\Pagination\WhereInWalker::isExpressionExistsInFromClause() does not have native type hint for its parameter $expression but it should be possible to add it based on @param annotation "mixed".
coding-standards / Coding Standards (PHP: 8.3): tests/Tests/ORM/Tools/Pagination/PaginatorTest.php#L15
Type Doctrine\ORM\Query\QueryException is not used in this file.
coding-standards / Coding Standards (PHP: 8.3): tests/Tests/ORM/Tools/Pagination/PaginatorTest.php#L20
Expected 1 line between different types of use statement, found 0.
coding-standards / Coding Standards (PHP: 8.3): tests/Tests/ORM/Tools/Pagination/PaginatorTest.php#L115
Usage of short nullable type hint in "?array" is disallowed.
coding-standards / Coding Standards (PHP: 8.3): tests/Tests/ORM/Tools/Pagination/PaginatorTest.php#L130
Use of annotation @dataProvider is forbidden.
coding-standards / Coding Standards (PHP: 8.3): tests/Tests/ORM/Tools/Pagination/PaginatorTest.php#L134
Multi-line function declaration must have a trailing comma after the last parameter.
coding-standards / Coding Standards (PHP: 8.3)
Process completed with exit code 1.