Stop type conversion for certain keys in query #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
malarzm
commented
Jun 26, 2020
malarzm
commented
| Q | A |
|---|---|
| Type | bug |
| BC Break | no |
| Fixed issues | #2193, #2194, #2199 |
malarzm
changed the title
This was referenced Jun 26, 2020
malarzm
force-pushed
the
prepare-expressions
branch
from
d91b02c to
53fa39d
Compare
Plopix
approved these changes
Jun 29, 2020
alcaeus
approved these changes
Jun 30, 2020
| @@ -1031,6 +1031,10 @@ private function convertToDatabaseValue(string $fieldName, $value) | |||
| { | |||
| if (is_array($value)) { | |||
| foreach ($value as $k => $v) { | |||
| if ($k === '$exists' || $k === '$type' || $k === '$currentDate') { | |||
There was a problem hiding this comment.
Looking at the query operators in MongoDB, there are a few more that we'll want to take another look at ($expr, $text, $mod, etc.) as they don't require type conversion based on the field type. However, I'm fine taking care of those in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.