Add missing parent::configure() call #2202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theyough thank you for the PR? Would you mind targeting the 1.3.x branch as we need to fix this but in the lowest supported branch? |
malarzm
changed the title
|
@malarzm , sorry i was a bit in rush, yesterday.i will do. Thank you |
|
@malarzm it appears from what i see, that this bug beginning from branch 2.X |
|
@theyough the call is missing in |
|
Yes but there is no parent::configure() method
…On Mon, Jun 22, 2020, 12:54 Maciej Malarz ***@***.***> wrote:
@theyough <https://github.com/theyough> the call is missing in 1.3.x as
well:
https://github.com/doctrine/mongodb-odm/blob/1.3.x/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/ShardCommand.php#L29
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2202 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWH65DYO75RISTUL3NWT4LRX4Z5BANCNFSM4OD53KUA>
.
|
|
Ah sorry, my bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
see issue details