Introduce Versionable interface #2184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
force-pushed
the
versionable-interface
branch
2 times, most recently
from
c9d7f1c to
2d071af
Compare
alcaeus
reviewed
May 18, 2020
| interface Versionable | ||
| { | ||
| /** | ||
| * Calculates next version. |
There was a problem hiding this comment.
Maybe we should add a hint that null will be passed if no current version exists?
There was a problem hiding this comment.
I put it into @param WDYT?
malarzm
force-pushed
the
versionable-interface
branch
from
2d071af to
2d9a4e8
Compare
alcaeus
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2140