Favour bool and int over boolean and integer

[malarzm]

Closes #2124

[alcaeus]

Apart from the wording suggestion, the INTEGER and BOOLEAN constants in Doctrine\ODM\MongoDB\Types\Type should be deprecated as well.

[alcaeus]

Suggested change

	`boolean` and `integer` types have been deprecated. Use their shorthand counterparts: `bool` and `int` respectively.
	The `boolean` and `integer` mapping types have been deprecated. Use their shorthand counterparts: `bool` and `int` respectively.

[malarzm]

@alcaeus also while I'm here there's also oddly looking \Doctrine\ODM\MongoDB\Types\IntIdType type registered under int_id. Do you recall anything special about it that couldn't be achieved with int? Shall I also deprecate it?

[alcaeus]

One nit in the deprecation message I missed the first time around. Feel free to merge once it has been changed.

[alcaeus]

Missed this the first time around: please provide the package name in the message:

Suggested change

	'"%s" type was deprecated in 2.1 and will be removed in 3.0. Use "%s" instead.',
	'"%s" type was deprecated in doctrine/mongodb-odm 2.1 and will be removed in 3.0. Use "%s" instead.',

[malarzm]

Added in const as well 👍

[alcaeus]

I think deprecating it makes sense. The class itself provides no value, so deprecating it in favour of int (and using IntType in the mean time) makes sense. I decided to dig a bit and found that there's only one place where we actually use int_id:

mongodb-odm/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php

Line 1898 in efdde4c

$mapping['type'] = $this->generatorType === self::GENERATOR_TYPE_INCREMENT ? 'int_id' : 'custom_id';

I'm not sure why this uses int_id, but it may as well use int. That could easily be tested by changing it and seeing how much breaks. If that works, we can deprecate int_id entirely, just like we deprecate integer and boolean. Feel free to leave that to a separate PR since this is good to go.