Skip to content

Chaged the Text Search docs on language #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Chaged the Text Search docs on language #2164

merged 1 commit into from
Feb 14, 2020

Conversation

Alfro
Copy link
Contributor

@Alfro Alfro commented Feb 13, 2020

Q A
Type improvement?
BC Break no?
Fixed issues

Summary

When trying to do

        ->language('it')
        ->text('parole che stai cercando');

I get:
This method requires a $text operator (call text() first)

I assumed the docs was wrong. If I am somehow not understanding this, please feel free to close the PR.

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say you're correct. This is also mentioned in the method description:

/**
* Set the $language option for $text criteria.
*
* This method must be called after text().
*
* @see Expr::language()
* @see http://docs.mongodb.org/manual/reference/operator/text/
*/
public function language(string $language) : self

@alcaeus alcaeus changed the base branch from 2.0.x to 1.3.x February 14, 2020 11:31
@alcaeus alcaeus added this to the 1.3.7 milestone Feb 14, 2020
@alcaeus
Copy link
Member

alcaeus commented Feb 14, 2020

Rebased to fix this in 1.3.x. Thanks @Alfro!

@alcaeus alcaeus merged commit 14da812 into doctrine:1.3.x Feb 14, 2020
@alcaeus alcaeus self-assigned this Feb 14, 2020
@Alfro Alfro deleted the patch-1 branch February 17, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants