[class metadata] The property mapping is skipped if fieldName is wrong

[makasim]

If the fieldName defined (in xml mapping for example) is not matched any property it is just silently skipped here.

It is not like ORM work. It would throw an exception and force me to correct mapping:

ReflectionException: Property Payum\Paypal\ExpressCheckout\Nvp\Bridge\Doctrine\Entity\PaymentDetails::$tokenNotExist does not exist

If it is a bug I could try to fix.

[makasim]

any feedback from repo owners?

[jmikola]

Can you provide the full trace of the ORM exception? That doesn't look like something the ORM itself is throwing -- rather, it assumes the property exists and uses Reflection to access it. I agree that both libraries should behave consistently wherever possible.

@guilhermeblanco @beberlei @Ocramius: Thoughts? Should ORM be catching this with its own exception? Ignoring it?

[makasim]

@jmikola it is ReflectionException.

[Ocramius]

@jmikola I think the ORM would simply let the reflection exception bubble up. It's really broken mappings, not something to be catched/handled

[makasim]

@jmikola I agree with @Ocramius no matter what exception to throw.

[jmikola]

@makasim: Sorry, I missed both replies to this last week. Feel free to implement a fix for this and cross-reference the PR to this issue. Throwing a ReflectionException is fine for me.

Also, if you can add a test for this (expecting an exception for an unmapped field), that'd be appreciated. You can probably add a test case to Doctrine\ODM\MongoDB\Tests\Mapping\ClassMetadataTest() instead of one of the driver suites.

[alcaeus]

Fix was merged in 58e001e.