Make test insensitive to PHP version #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have two possible error messages depending on the version of PHP, and recently, a third made its appearance. Let us use a regex to match this message from PCRE (very meta, I know). See php/php-src#13068
greg0ire
force-pushed
the
adapt-to-error-message-change
branch
from
76eb199 to
5741900
Compare
greg0ire
force-pushed
the
adapt-to-error-message-change
branch
from
fe0c09b to
41e8df8
Compare
SenseException
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have two possible error messages depending on the version of PHP, and recently, a third made its appearance. Let us use a regex to match this message from PCRE (very meta, I know).
See php/php-src#13068
This didn't get caught earlier, probably because we were not running tests with PHP 8.4. This is now addressed as well.