Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code cleanup #91

Closed
wants to merge 15 commits into from
Closed

Dead code cleanup #91

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
17c22e1
[Connection] removed unused local variable $position in Connection cl…
Jan 12, 2012
30f0195
[Connection] removed unused local variables $index and $fieldName in …
Jan 12, 2012
62876eb
[Platforms] removed unused local variables $index_ and $fieldName in …
Jan 12, 2012
78f2a20
[Platforms] removed unused local variable $fieldName in MysqlPlatform…
Jan 12, 2012
a8b9f89
[Platforms] removed unused local variables $indexName and $definition…
Jan 12, 2012
750036e
[DBAL] removed unused local variable $token in SQLParserUtils class.
Jan 12, 2012
196cbef
[Schema] removed all occurrences of unused local variable $key in sev…
Jan 12, 2012
b672e95
[Schema] removed unused local variable $candidate in Comparator class.
Jan 12, 2012
24e9573
[Schema] removed unused local variable $tableIndexRows in DB2SchemaMa…
Jan 12, 2012
5dc01e7
[Schema] removed unused local variable $def in MysqlSchemaManager class.
Jan 12, 2012
5cfc064
[Schema] removed unused local variable $key in OracleSchemaManager cl…
Jan 12, 2012
ad22cc4
[Schema] removed unused local variables $column and $columnName in Ta…
Jan 12, 2012
7207664
[Schema] fixed CS.
Jan 12, 2012
e35cf23
[DBAL] fixed some CS and renamed all "AS" keywords to "as".
Jan 12, 2012
897b635
[Schema] fixed CS.
Jan 12, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Platforms] removed unused local variables $indexName and $definition… 
… in OraclePlatform class.
  • Loading branch information
Hugo Hamon committed Jan 12, 2012
commit a8b9f8907a00a8a44147708314ec432e1c9a7795
7 changes: 1 addition & 6 deletions lib/Doctrine/DBAL/Platforms/OraclePlatform.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ protected function _getCreateTableSQL($table, array $columns, array $options = a
}

if (isset($indexes) && ! empty($indexes)) {
foreach ($indexes as $indexName => $index) {
foreach ($indexes AS $index) {
$sql[] = $this->getCreateIndexSQL($index, $table);
}
}
Expand Down Expand Up @@ -408,11 +408,6 @@ public function getCreateAutoincrementSql($name, $table, $start = 1)
$sql = array();

$indexName = $table . '_AI_PK';
$definition = array(
'primary' => true,
'columns' => array($name => true),
);

$idx = new \Doctrine\DBAL\Schema\Index($indexName, array($name), true, true);

$sql[] = 'DECLARE
Expand Down