Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3.8.x up into 4.0.x #6417

Merged
merged 7 commits into from
Jun 2, 2024
Prev Previous commit
Next Next commit
Fix test names to reflect their actual purpose
Both tests did expect a name change to result in an empty table diff in
the past. When index renaming support was introduced the name of the
test was not changed to reflect the new expectation.

Signed-off-by: Christoph Krapp <christoph.krapp@power.cloud>
  • Loading branch information
Christoph Krapp committed Jun 1, 2024
commit 422e459e4b12aad01ea86fa9ad87afeacddc4998
4 changes: 2 additions & 2 deletions tests/Schema/AbstractComparatorTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ public function testCompareColumnCompareCaseInsensitive(): void
self::assertFalse($tableDiff);
}

public function testCompareIndexBasedOnPropertiesNotName(): void
public function testDetectIndexNameChange(): void
{
$tableA = new Table('foo');
$tableA->addColumn('id', Types::INTEGER);
Expand All @@ -672,7 +672,7 @@ public function testCompareIndexBasedOnPropertiesNotName(): void
);
}

public function testCompareForeignKeyBasedOnPropertiesNotName(): void
public function testDetectForeignKeyNameChange(): void
{
$tableA = new Table('foo');
$tableA->addColumn('id', Types::INTEGER);
Expand Down