Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PostgreSQL omit dropped columns in getListTableColumnsSQL (pg_att… #6249

Open
wants to merge 4 commits into
base: 3.9.x
Choose a base branch
from

Conversation

kamil-michalak
Copy link

…ribute table) to avoid ........pg.dropped.x.......

Q A
Type bug
Fixed issues #6248

Summary

Avoid fetching deleted columns for tables structure

…ribute table) to avoid ........pg.dropped.x.......

Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
@derrabus
Copy link
Member

Thank you. Please add a functional test that covers your change.

…ribute table) to avoid ........pg.dropped.x....... - test

Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
…ribute table) to avoid ........pg.dropped.x....... - test fix

Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
…ribute table) to avoid ........pg.dropped.x....... - test fix

Signed-off-by: Kamil Michalak <k.michalak@kstudio.pl>
@kamil-michalak
Copy link
Author

@derrabus please review.

Comment on lines +35 to +48
public function testPgSqlPgAttributeTable(): void
{
$platform = $this->connection->getDatabasePlatform();

if (!$platform instanceof PostgreSQLPlatform) {
self::markTestSkipped('Test does work on PostgreSQL only.');
}

try {
$this->connection->executeQuery('Select attisdropped from pg_attribute Limit 1')->fetchOne();
} catch (Throwable $e) {
self::fail("Column attisdropped not exists in pg_attribute table");
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this test?

@derrabus derrabus changed the base branch from 3.7.x to 3.8.x January 25, 2024 22:57
@Vision42
Copy link

Vision42 commented Mar 5, 2024

What is the status here? I have now also stumbled across this bug and the changes in this pull request have fixed it locally. Is the PR still in development?
Otherwise, I would offer to take this over and create a new pull request based on the above changes.

@derrabus
Copy link
Member

derrabus commented Mar 6, 2024

I would offer to take this over and create a new pull request based on the above changes.

Yes, please do that.

This comment has been minimized.

@github-actions github-actions bot added the Stale label Jun 5, 2024
@derrabus

This comment has been minimized.

@derrabus derrabus removed the Stale label Jun 5, 2024
@SenseException
Copy link
Member

@Vision42 Did you find some time to take on this PR?

@derrabus derrabus changed the base branch from 3.8.x to 3.9.x August 14, 2024 11:00
@ahmadsyamim
Copy link

@derrabus Is there a timeline for the merger of this pull request?

@derrabus
Copy link
Member

@derrabus Is there a timeline for the merger of this pull request?

No. It's incomplete and obviously nobody's working on it.

@ahmadsyamim
Copy link

@derrabus
Could you please clarify the remaining tasks necessary to approve this pull request?

@derrabus
Copy link
Member

Well, the CI is red and the comments from my last review haven't been addressed. What do you want me to clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants