MySQLSchemaManager: Check expected database type for json columns only #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the type from DC2Type comments masks the need to upgrade LONGTEXT columns to JSON so the underlying column type was also checked for commented columns. Custom column types using a valid synonym for column type (e.g. NUMERIC for DECIMAL), trigger a false failure of this type test. Restrict the check to json types only. Add test case. See bug doctrine#6185.
cs278
reviewed
Oct 14, 2023
| */ | ||
| public function getMappedDatabaseTypes(AbstractPlatform $platform) | ||
| { | ||
| return ['point']; |
There was a problem hiding this comment.
Oops. No. Thanks for spotting. Now removed.
Remove getMappedDatabaseTypes() method included by mistake.
derrabus
approved these changes
Nov 2, 2023
|
Thank you. |
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 3, 2023
* 3.8.x: Run tests on MySQL 8.2 (doctrine#6207) MySQLSchemaManager. Check expected database type for json columns only. (doctrine#6189) Make the type annotation for CompositeExpression::count more specific (doctrine#6188)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 5, 2023
* 3.8.x: Run tests on MySQL 8.2 (doctrine#6207) MySQLSchemaManager. Check expected database type for json columns only. (doctrine#6189) Make the type annotation for CompositeExpression::count more specific (doctrine#6188)
derrabus
changed the title
derrabus
added a commit
that referenced
this pull request
Nov 5, 2023
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | Follows #6189 #### Summary This PR improves the test added in #6189 by allowing it to run on other platforms than MySQL/MariaDB and by using non-deprecated APIs only. This should make it easier to merge this test and later changes to it up to the 4.0.x branch. I've skipped Oracle though because I currently don't have a local Oracle setup to test against.
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 5, 2023
* 3.8.x: Generalize CustomIntrospectionTest (doctrine#6210) Run tests on MySQL 8.2 (doctrine#6207) MySQLSchemaManager. Check expected database type for json columns only. (doctrine#6189) Make the type annotation for CompositeExpression::count more specific (doctrine#6188)
allan-simon
pushed a commit
to allan-simon/dbal
that referenced
this pull request
Nov 13, 2023
…y. (doctrine#6189) | Q | A |------------- | ----------- | Type | bug fix | Fixed issues | doctrine#6185 #### Summary Using the type from DC2Type comments masks the need to upgrade LONGTEXT columns to JSON so the underlying column type was also checked for commented columns. Custom column types using a valid synonym for column type (e.g. NUMERIC for DECIMAL), trigger a false failure of this type test. Restrict the check to json types only and add test case.
allan-simon
pushed a commit
to allan-simon/dbal
that referenced
this pull request
Nov 13, 2023
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | Follows doctrine#6189 #### Summary This PR improves the test added in doctrine#6189 by allowing it to run on other platforms than MySQL/MariaDB and by using non-deprecated APIs only. This should make it easier to merge this test and later changes to it up to the 4.0.x branch. I've skipped Oracle though because I currently don't have a local Oracle setup to test against.
|
Thank you @cgknx |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using the type from DC2Type comments masks the need to upgrade LONGTEXT columns to JSON so the underlying column type was also checked for commented columns.
Custom column types using a valid synonym for column type (e.g. NUMERIC for DECIMAL), trigger a false failure of this type test.
Restrict the check to json types only and add test case.