Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TestLogger instead of mocks #5903

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Use TestLogger instead of mocks #5903

merged 1 commit into from
Feb 3, 2023

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Feb 3, 2023

Q A
Type improvement
Fixed issues N/A

Summary

While hunting down calls to the deprecated withConsecutive() PHPUnit method, I have replaced our mocked logger from test tests of our logging middleware with the TestLogger class from the fig/log-test package.

@derrabus derrabus added this to the 3.5.4 milestone Feb 3, 2023
@derrabus derrabus merged commit cbcd7d7 into doctrine:3.5.x Feb 3, 2023
@derrabus derrabus deleted the improvement/test-logger branch February 3, 2023 22:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
Test Suite
Projects
None yet
Milestone
3.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabus @SenseException