Add missing doc blocks to Index and UniqueConstraint #5875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Jan 28, 2023
| } | ||
|
|
||
| $chunks[] = sprintf('(%s)', implode(', ', $columnSQL)); | ||
| $chunks[] = sprintf('(%s)', implode(', ', $columns)); |
There was a problem hiding this comment.
If $columns is always a list of strings, the whole foreach loop doesn't make sense. 🧐
greg0ire
approved these changes
Jan 28, 2023
| @@ -366,7 +366,7 @@ public function getAlterTableSQL(TableDiff $diff): array | |||
| // Necessary in case the new primary key includes a new auto_increment column | |||
| foreach ($modifiedIndexes['primary']->getColumns() as $columnName) { | |||
| if (isset($addedColumns[$columnName]) && $addedColumns[$columnName]->getAutoincrement()) { | |||
| $keyColumns = array_unique(array_values($modifiedIndexes['primary']->getColumns())); | |||
| $keyColumns = array_values(array_unique($modifiedIndexes['primary']->getColumns())); | |||
There was a problem hiding this comment.
The previous code didn't make sense. getColumns() returns a list, so it's pointless to call array_values() on it.
array_unique() however does not reindex the passed array, so if you pass a list to it with at least one duplicate, the returned array won't be a list anymore. Thus is makes sense to call array_values() in the result of the array_unique() operation if we want the array to remain a list after eliminating duplicates.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the removal of the
Constraintinterface in #4842, theIndexandUniqueConstraintclasses were left with@inheritdocblocks that point nowhere.This PR restores the original doc blocks and fixes follow-up issues reported by PHPStan and Psalm.