Allow passing url to override params #5862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update OverrideParams array shape in DriverManager to allow passing url
greg0ire
approved these changes
Jan 12, 2023
derrabus
approved these changes
Jan 12, 2023
|
Thanks @keulinho |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OverrideParams array shape in DriverManager to allow passing url
Summary
The url parameter was removed in type hints (probably accidentally in the 3.5 branch as there passing an url should still be allowed, it was only removed for 4.0).
This is similiar to #5857, but in the
OverrideParamstheurlparam was still not allowed.But in fact it should be allowed as it should still be possible to configure e.g replica connections with an url.