-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document breaking changes about serverVersion #5797
Conversation
On 4.0, is it necessary to use Maybe we should document and test the format like Otherwise, MariaDB users have no idea how to explicitly specify it. |
Dunno. Where did you get that idea from?
I think it's a good idea. What are users typically using before? |
Seems that
Sure, as it's suggested by the official doc. |
@bohanyang I'm not following you, please clarify what you mean and how it relates to this. |
@@ -292,9 +292,6 @@ the corresponding platform class. | |||
You can also pass the ``serverVersion`` option if you want to disable automatic | |||
database platform detection and choose the platform version implementation explicitly. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is that should we change this paragraph to something like the following rather than completely removing it:
The value of `serverVersion` option should be a complete and valid version string, just like the response to a query of database version.
For example when using MySQL or MariaDB, it should be what returned by `SELECT VERSION();`,
like '10.9.3-MariaDB-1:10.9.3+maria~ubu2204'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 if we add this to the docs, we should add it to 3.6.x IMO, or even on 3.5.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, let's change the docs on 3.5.x already.
Shouldn't a version string like |
Yes |
ec40ad0
to
bf25877
Compare
No description provided.