Deprecate SchemaException codes #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
deprecate-schema-exception-codes
branch
from
610cf7e to
9fd0452
Compare
morozov
force-pushed
the
deprecate-schema-exception-codes
branch
from
9fd0452 to
2ceb2d3
Compare
How is that in issue? Interfaces can have constants. |
greg0ire
approved these changes
Oct 7, 2022
I didn't know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #5726 and #5727, I want to convert
SchemaExceptionto an interface and declare some of its subclasses asLogicException. The problem with that is thatSchemaExceptiondefines constants.As of #3525, each of the constants has a corresponding class, so as an API, these constants are redundant.
In order to provide an upgrade path, we need to backport the introduction of
SchemaExceptionsubclasses from 4.0.x.