Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated isFullfilledBy() method #5724

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Removing deprecated isFullfilledBy() method #5724

merged 2 commits into from
Oct 5, 2022

Conversation

nexxai
Copy link
Contributor

@nexxai nexxai commented Oct 5, 2022

Q A
Type improvement
Fixed issues #5722

Summary

Removing deprecated isFullfilledBy() method

greg0ire
greg0ire previously approved these changes Oct 5, 2022
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update UPGRADE.md

@derrabus derrabus added this to the 4.0.0 milestone Oct 5, 2022
@nexxai
Copy link
Contributor Author

nexxai commented Oct 5, 2022

@derrabus Sorry about that - I updated it for the 3.5.x deprecation but didn't realize it needed a separate line for the BC. Have gone ahead and added that notice.

@nexxai nexxai requested a review from derrabus October 5, 2022 14:51
@derrabus derrabus merged commit c9d3753 into doctrine:4.0.x Oct 5, 2022
@derrabus
Copy link
Member

derrabus commented Oct 5, 2022

Thanks!

greg0ire added a commit to greg0ire/doctrine-orm that referenced this pull request Oct 6, 2022
greg0ire added a commit to greg0ire/doctrine-orm that referenced this pull request Oct 6, 2022
greg0ire added a commit to greg0ire/doctrine-orm that referenced this pull request Oct 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants