Do not use ColumnDiff::$changedProperties in OraclePlatform::getAlterTableSQL() #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of counting changed properties, the code should check whether the resulting column declaration has changed.
This renders the test being removed invalid because it uses the diff that declares changed properties but the from and the to columns are the same. The original test implementation introduced in #360 was correct but it was incorrectly updated in #4786. It is not worth fixing the test since there is a functional test that covers the same logic (
OracleSchemaManagerTest::testAlterTableColumnNotNull()).