Drop PHP 8.0 support #5543
Merged
Drop PHP 8.0 support #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To fix the low-deps job, change the version constraint of Symfony Console: "symfony/console": "^4.4.30|^5.4|^6.0"Alternatively, kick the 4.4 branch completely. It'll be security-only in a couple of months "symfony/console": "^5.4|^6.0" |
derrabus
approved these changes
Jul 28, 2022
morozov
commented
Jul 28, 2022
| @@ -64,8 +64,7 @@ install: | |||
| Add-Content php.ini "`n extension=php_sqlite3.dll" | |||
| Add-Content php.ini "`n extension=php_curl.dll" | |||
|
|
|||
| # Get and install the latest stable sqlsrv DLL's | |||
| $DLLVersion = (Invoke-WebRequest "https://pecl.php.net/rest/r/sqlsrv/stable.txt").Content | |||
| $DLLVersion = "5.10.0" | |||
There was a problem hiding this comment.
Windows builds are not always up to speed with PECL. According to PECL, the latest stable version is 5.10.1 but there are no corresponding Windows binaries.
It's been working so far thanks to the AppVeyor cache. We can switch back to the latest stable later once they sync up.
greg0ire
approved these changes
Jul 28, 2022
This was referenced Jul 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current plan is to release DBAL 4.0 while PHP 8.0 is still officially supported by the community. However, dropping its support now will allow for making some improvements.
For instance, we could replace the
ParameterTypeclass and similar ones with an enum and introduce more enums (e.g. for the foreign key constraint actions). Since this is a breaking change, not doing it now will require us to wait for another major DBAL release.The support for PHP 8.0 is not part of the upgrade path from earlier DBAL versions. PHP 8.1 is also supported by DBAL 3.x.