Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-public API cleanup in AbstractSchemaManager #5456

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Non-public API cleanup in AbstractSchemaManager #5456

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ebbe11b
Inline some AbstractSchemaManager::_getPortable*List() methods
morozov Jun 19, 2022
7a29e0d
Remove default implementation of AbstractSchemaManager::_getPortableD…
morozov Jun 20, 2022
0bec586
Make AbstractSchemaManager::_getPortableViewDefinition() abstract
morozov Jun 20, 2022
b34afe5
Make AbstractSchemaManager::_getPortableTableDefinition() abstract
morozov Jun 20, 2022
27aa10e
Make AbstractSchemaManager::filterAssetNames() private
morozov Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove default implementation of AbstractSchemaManager::_getPortableD… 
…atabaseDefinition()
  • Loading branch information
@morozov
morozov committed Jun 20, 2022
commit 7a29e0da2c4f66936c432e872056866c37bbb57d
6 changes: 3 additions & 3 deletions src/Schema/AbstractSchemaManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,12 +616,12 @@ public function renameTable(string $name, string $newName): void

/**
* @param array<string, string> $database
*
* @throws Exception
*/
protected function _getPortableDatabaseDefinition(array $database): string
{
assert(! empty($database));

return array_shift($database);
throw NotSupported::new(__METHOD__);
}

/**
Expand Down