Remove the APIs deprecated in DBAL 3.x #5423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
remove-deprecations
branch
from
f9f592c to
56d383e
Compare
morozov
commented
Jun 2, 2022
| @@ -169,6 +169,8 @@ public function testReturnQuotedAssets(): void | |||
| [ | |||
| 'CREATE TABLE dbal91_something (id INT NOT NULL, "table" INT DEFAULT NULL, PRIMARY KEY(id))', | |||
| 'CREATE INDEX IDX_A9401304ECA7352B ON dbal91_something ("table")', | |||
| 'ALTER TABLE dbal91_something ADD CONSTRAINT something_input FOREIGN KEY ("table")' | |||
| . ' REFERENCES dbal91_something (id) ON UPDATE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE', | |||
There was a problem hiding this comment.
This change should have been made in #5416 if we wanted to be absolutely deprecation-free but we don't.
greg0ire
approved these changes
Jun 2, 2022
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Oct 7, 2022
The exception is unused as of doctrine#5423.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the following pull requests for reference:
Notes:
AbstractPlatform::CREATE_*constants cannot be deprecated in 3.x and removed in 4.0 since they are part of the upgrade path.testQuoteIdentifier()andtestQuoteSingleIdentifier()are covered by the integrationQuoteTest.