Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReturnTypeWillChange attribute #4973

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Nov 9, 2021

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

The method received the correct return type on the 4.0.x branch, so we don't need the attribute anymore.

Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus added the PHP label Nov 9, 2021
@derrabus derrabus added this to the 4.0.0 milestone Nov 9, 2021
@derrabus derrabus merged commit 92e30b8 into doctrine:4.0.x Nov 9, 2021
@derrabus derrabus deleted the remove/return-type-will-change branch November 9, 2021 17:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants