Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for CREATE|DROP DATABASE in SQLite schema manager #4965

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Drop support for CREATE|DROP DATABASE in SQLite schema manager #4965

merged 1 commit into from
Nov 9, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Nov 7, 2021 •
edited
Loading

Q A
Type improvement
BC Break yes

Closes #4963.

@morozov morozov added this to the 3.2.0 milestone Nov 7, 2021
@morozov morozov force-pushed the issues/4963-sqlite-drop-create-database branch from 787adb6 to 16617b0 Compare November 7, 2021 19:26
@morozov morozov requested review from derrabus and greg0ire November 7, 2021 19:58
@derrabus
Copy link
Member

derrabus commented Nov 8, 2021

Doesn't this break existing applications that use the schema manager to delete and recreate an SQLite file?

@morozov
Copy link
Member Author

morozov commented Nov 9, 2021 •
edited
Loading

Doesn't this break existing applications that use the schema manager to delete and recreate an SQLite file?

I think it does but only in the case if they don't respect the return value of supportsCreateDropDatabase() (which is part of the API).

I believe we can deprecate this behavior in 3.2.x (#4969) and drop it in 4.0.0.

@morozov morozov marked this pull request as draft November 9, 2021 01:45
@morozov morozov mentioned this pull request Nov 9, 2021
Merged
@morozov morozov changed the base branch from 3.2.x to 4.0.x November 9, 2021 17:09
@morozov morozov force-pushed the issues/4963-sqlite-drop-create-database branch from 16617b0 to 0b89f5b Compare November 9, 2021 17:09
@morozov morozov modified the milestones: 3.2.0, 4.0.0 Nov 9, 2021
@morozov morozov force-pushed the issues/4963-sqlite-drop-create-database branch from 0b89f5b to 587c332 Compare November 9, 2021 21:26
@morozov morozov changed the title Declare SQLite as not supporting CREATE|DROP DATABASE Drop support for CREATE|DROP DATABASE in SQLite schema manager Nov 9, 2021
@morozov morozov marked this pull request as ready for review November 9, 2021 21:31
@derrabus derrabus merged commit 3fbd076 into doctrine:4.0.x Nov 9, 2021
@morozov morozov deleted the issues/4963-sqlite-drop-create-database branch November 9, 2021 23:17
@morozov morozov linked an issue Nov 10, 2021 that may be closed by this pull request
Inconsistent semantics of createDatabase() and dropDatabase() for SQLite #4963
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
BC Break Platforms Schema Management SQLite
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

Inconsistent semantics of createDatabase() and dropDatabase() for SQLite
2 participants
@morozov @derrabus