Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant PHPUnit mocks #4964

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Nov 7, 2021

Q A
Type improvement
BC Break no

PHPUnit is capable of generating mocks for the return values if their type is known.

@morozov morozov added this to the 4.0.0 milestone Nov 7, 2021
@morozov morozov requested review from derrabus and greg0ire November 7, 2021 19:53
@derrabus derrabus merged commit 2f7e154 into doctrine:4.0.x Nov 7, 2021
@morozov morozov deleted the remove-redundant-mocks branch November 7, 2021 21:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants