Mark Statement::execute() private, remove QueryBuilder::execute() #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
Oct 2, 2021
| ->from('foo') | ||
| ->execute(); | ||
|
|
||
| self::assertInstanceOf(Result::class, $result); |
There was a problem hiding this comment.
This expectation is now enforced at the API level.
morozov
commented
Oct 2, 2021
| <!-- | ||
| TODO: remove in 4.0.0 | ||
| --> | ||
| <referencedMethod name="Doctrine\DBAL\Schema\Schema::getMigrateToSql"/> |
There was a problem hiding this comment.
This one is a leftover from a previous deprecated API removal.
morozov
force-pushed
the
remove-execute
branch
from
d4b9d24 to
ef69284
Compare
derrabus
reviewed
Oct 2, 2021
derrabus
approved these changes
Oct 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4580.