Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original case to index renamed columns #4817

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 27, 2021

Q A
Type bug
BC Break unclear

Fixes #4816.

Depending on what's considered the API, this change may constitute a minor BC break: instead of containing lower-cased names, renamedColumns will contain the original names while the table definition still uses lower-cased column names for indexing columns.

@morozov morozov marked this pull request as ready for review December 29, 2021 16:11
@morozov morozov requested review from derrabus and greg0ire December 30, 2021 17:34
@morozov morozov merged commit f2cb8eb into doctrine:3.3.x Dec 30, 2021
@morozov morozov deleted the issues/4816 branch December 30, 2021 18:56
@morozov morozov added this to the 3.3.0 milestone Dec 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants