Deprecate AbstractPlatform::canEmulateSchemas() #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
deprecate-can-emulate-schemas
branch
from
8349860 to
65a8902
Compare
To me, this looks like the ORM uses this "feature" so Postgres functionality can be tested on SQLite. 🙈 Yes, please remove it from DBAL. |
derrabus
approved these changes
Sep 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "schema emulation" feature as it's currently implemented in the DBAL doesn't belong to the DBAL. The emulation is effectively replacing the dot in the table names with a double underscore, assuming the dot is a fully qualified name separator (see #4804), which isn't always true (see #4708).
It is used by the ORM but since the ORM owns the table names, it can do the same replacement itself and emulate the schema on any platform. As such, this feature is really questionable. I wouldn't trust the results of such tests.
There isn't a single test in the DBAL that would cover this feature.