Deprecate not passing $fromColumn to ColumnDiff #4785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Sep 10, 2021
morozov
force-pushed
the
deprecate-partial-column-diff
branch
from
249251c to
a8dd2d3
Compare
greg0ire
approved these changes
Sep 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$fromColumnparameter is optional since its introduction in #220. It had to be declared as optional to avoid a BC break. The fact that not passing it wasn't immediately deprecated, requires the code that interprets the diff to interpret it in two modes: with and without the$fromColumn.Given that the property-based comparison is deprecated (#4746), the next step is to stop using
$changedPropertiesand only rely on the actual column definitions. For that, we need to require$fromColumnto be always set.Once we stop using
$changedPropertiesin4.0.x, we can deprecate it.