Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove platform-unaware schema comparison API #4771

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Remove platform-unaware schema comparison API #4771

merged 1 commit into from
Sep 8, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Aug 29, 2021

Q A
Type improvement
BC Break yes

See #4746.

@morozov morozov added this to the 4.0.0 milestone Aug 29, 2021
@morozov morozov force-pushed the remove-platform-unaware-comparison branch from ebab650 to 309da3f Compare August 29, 2021 23:10
@morozov morozov marked this pull request as ready for review August 29, 2021 23:18
@morozov morozov requested review from greg0ire and derrabus August 29, 2021 23:18
@morozov morozov merged commit cd62cf4 into doctrine:4.0.x Sep 8, 2021
@morozov morozov deleted the remove-platform-unaware-comparison branch September 8, 2021 21:26
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2022
@morozov
Remove compensating for a schema comparison flaw
771d873 
This code was relevant before the improvement in
doctrine#4746 was implemented. The new
comparator API is enforced in
doctrine#4771.

Now, the comparator will not produce a false-positive diff which is
enforced by the new test.
@morozov morozov mentioned this pull request Aug 26, 2022
Merged
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2022
@morozov
Remove code compensating for a schema comparison flaw
c20d091 
This code was relevant before the improvement in
doctrine#4746 was implemented. The new
comparator API is enforced in
doctrine#4771.

Now, the comparator will not produce a false-positive diff which is
enforced by the new test.
@morozov morozov mentioned this pull request Sep 1, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
BC Break Improvement Schema Comparison
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @greg0ire @SenseException